Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update addon template design to support specifying signerCA namespace #135

Conversation

zhujian7
Copy link
Member

@zhujian7 zhujian7 commented Dec 6, 2024

@openshift-ci openshift-ci bot requested review from deads2k and qiujian16 December 6, 2024 09:36
@qiujian16
Copy link
Member

qiujian16 commented Dec 9, 2024

also needs to update the metadata.yaml with updated lastModified

@qiujian16
Copy link
Member

/approve
/lgtm

Copy link

openshift-ci bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2b86e70 into open-cluster-management-io:main Dec 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants